Skip to content

APP-17192: return per-file URLs from sequence dataset export - #882

Open
Vignesh P (vpandiarajan20) wants to merge 3 commits into
mainfrom
app-17192-export-parquet-files
Open

APP-17192: return per-file URLs from sequence dataset export#882
Vignesh P (vpandiarajan20) wants to merge 3 commits into
mainfrom
app-17192-export-parquet-files

Conversation

@vpandiarajan20

@vpandiarajan20 Vignesh P (vpandiarajan20) commented Jul 22, 2026

Copy link
Copy Markdown
Member

Adds repeated SequenceDatasetExportFile files to GetSequenceDatasetExportResponse and removes the single download_url.
The export produces three independent parquet files, and zipping them forces serialization into one stream, so app currently buffers two of them fully in memory while the third is written: domains/dataset/export.go#L61-L88 (internal repo) shows the three generators each filling a bytes.Buffer before the zip is assembled.

🤖 Generated with Claude Code

@github-actions github-actions Bot added the safe to test committer is a member of this org label Jul 22, 2026
The sequence dataset export produces three independent parquet files
(sequences, tabular data, binary data). Packaging them into a single zip
forces them to be serialized into one stream, so app must buffer two of
the three fully in memory while the third is written.

Returning one signed URL per file removes that constraint: each file can
stream directly to object storage in parallel, making export memory flat
regardless of dataset size. It also lets consumers that only need one
file (e.g. training jobs reading tabular data) skip the other two.

download_url is reserved rather than deprecated because it will never be
populated again. Repo convention reserves fields that stop carrying data
and deprecates only those that still work; this requires the
'allow breaking' label.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vpandiarajan20
Vignesh P (vpandiarajan20) force-pushed the app-17192-export-parquet-files branch from d18a286 to 533cdec Compare July 22, 2026 17:20
@vpandiarajan20 Vignesh P (vpandiarajan20) added allow breaking Allow breaking changes by bypassing the buf-breaking check ready-for-protos add this when you want protos to compile on every commit labels Jul 22, 2026
@vpandiarajan20
Vignesh P (vpandiarajan20) marked this pull request as ready for review July 28, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allow breaking Allow breaking changes by bypassing the buf-breaking check protos-compiled ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant