Skip to content

[APP-16771] Add count to SequencesByDatasetIDResponse - #883

Merged
Naveed Jooma (njooma) merged 3 commits into
viamrobotics:mainfrom
njooma:APP-16771/sequences-count
Jul 27, 2026
Merged

[APP-16771] Add count to SequencesByDatasetIDResponse#883
Naveed Jooma (njooma) merged 3 commits into
viamrobotics:mainfrom
njooma:APP-16771/sequences-count

Conversation

@njooma

Copy link
Copy Markdown
Member

So that we can appropriately display the number of total sequences in a dataset, even when paginated

@github-actions github-actions Bot added the safe to test committer is a member of this org label Jul 23, 2026
@vpandiarajan20

Copy link
Copy Markdown
Member

Would this return the full number of sequences in the dataset?

  • If so, then this would be another database query, right?
  • If not, then we'd have to call this endpoint multiple times to get the full number.

Why don't we add another endpoint, like we did for binary data datasets?

@njooma

Copy link
Copy Markdown
Member Author

Vignesh P (@vpandiarajan20) the goal is to have it return total count.

I don't think we have a separate endpoint for binary datasets? BinarayDataByDatasetID is internal (can see it in App but not API). The request for that does allow users to request countOnly, though, maybe we do that too? Or I could just write a new endpoint internally only

@vpandiarajan20

Copy link
Copy Markdown
Member

Vignesh P (Vignesh P (@vpandiarajan20)) the goal is to have it return total count.

I don't think we have a separate endpoint for binary datasets? BinarayDataByDatasetID is internal (can see it in App but not API). The request for that does allow users to request countOnly, though, maybe we do that too? Or I could just write a new endpoint internally only

You're totally right, I think countOnly makes sense. Let's do that. I think you need to send out a quick scope email because its a public API change?

@njooma

Naveed Jooma (njooma) commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

I think you need to send out a quick scope email because its a public API change?

I usually don't if it's additive/non-breaking, but maybe I'm supposed to be...

@njooma Naveed Jooma (njooma) added the ready-for-protos add this when you want protos to compile on every commit label Jul 24, 2026
@njooma Naveed Jooma (njooma) added safe to test committer is a member of this org protos-compiled and removed safe to test committer is a member of this org protos-compiled labels Jul 27, 2026
@njooma
Naveed Jooma (njooma) force-pushed the APP-16771/sequences-count branch from 56c008d to 037be76 Compare July 27, 2026 18:28
@njooma
Naveed Jooma (njooma) merged commit 366d659 into viamrobotics:main Jul 27, 2026
1 check passed
@njooma
Naveed Jooma (njooma) deleted the APP-16771/sequences-count branch July 27, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

protos-compiled ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants