RSDK-11037 Add geometries to sensor component - #159
Conversation
The sensor component was the only component with a GetGeometries RPC in the API that did not expose getGeometries through its RPC client and RPC service. Implement the client and server handlers following the existing pattern (e.g. movement sensor) and add unit tests.
|
Hey Ale Paredes (@ale7714) — this PR has been approved and CI has been green for 3+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey Ale Paredes (@ale7714) — this PR has been approved and CI has been green for 9+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey Ale Paredes (@ale7714) — this PR has been approved and CI has been green for 15+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey Ale Paredes (@ale7714) — this PR has been approved and CI has been green for 21+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
|
Hey Ale Paredes (@ale7714) — this PR has been approved and CI has been green for 26+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
…Gum4Bpv4kj4Nvx3RqG
Summary
Part of the effort to expose
geometrieson every component that supports it (alongsideDoCommand).In the Java SDK, every component whose API defines a
GetGeometriesRPC already implementedgetGeometrieson both its RPC client and RPC service — exceptsensor, whoseSensorRPCClientandSensorRPCServicewere missing the override (the service file even had leftover, unused geometry imports from a copy of the movement sensor).This PR fills that gap so
sensoris consistent with the other components (arm, base, board, camera, encoder, gantry, generic, gripper, motor, movement sensor, pose tracker, servo, audio input, …).Changes
SensorRPCClient: implementgetGeometries(Optional<Struct> extra), calling theGetGeometriesRPC and returning the geometries list.SensorRPCService: implement thegetGeometriesserver handler, delegating to the resource (matchingMovementSensorRPCService).SensorRPCClientTestandSensorRPCServiceTest(the sensor component previously had no tests), coveringgetGeometries,getReadings, anddoCommand.Testing
./gradlew :core:viam-core-sdk:testpasses locally, including the new sensor tests.Key: RSDK-11037
Co-authored by Claude agent for Jira.