[spark-compete] fix: add timeout to icacls subprocess in _ensure_windows_file_permissions#912
Open
Esc1200 wants to merge 1 commit into
Open
[spark-compete] fix: add timeout to icacls subprocess in _ensure_windows_file_permissions#912Esc1200 wants to merge 1 commit into
Esc1200 wants to merge 1 commit into
Conversation
The icacls subprocess.run() call in _ensure_windows_file_permissions() lacked a timeout parameter. A hanging icacls process would block indefinitely. Added timeout=30.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Vulnerability Report
Team name: Bug Hunters
Team member(s): Esc1200
Severity Level: LOW
Vulnerability Description
The
icaclssubprocess.run() call in_ensure_windows_file_permissions()(cli.py:1092) lacked a timeout parameter. On Windows, a hangingicaclsprocess would block the function indefinitely, preventing the caller from proceeding.Fix Description
Added
timeout=30to the subprocess.run() call. 30 seconds is generous for a local permission-setting command.Affected Files
src/spark_cli/cli.pyTrust Boundary Impact
Input trust boundary: N/A — this is an internal permission-setting utility.
Output trust boundary: N/A — the function already catches OSError.
Security Design Statement
All subprocess calls should have bounded execution time. This fix ensures the icacls call cannot hang indefinitely.
{ "schema_version": "2.0", "pr": { "url": "https://github.com/vibeforge1111/spark-cli/pull/901", "body_must_include": ["Bug Hunters", "Esc1200"] } }