docs: correct the claim that a deploy cannot overwrite appsettings.local.json - #47
Merged
Merged
Conversation
…cal.json It was true of `dotnet publish` and false of `install-service.ps1 -FromZip`, which is the path people actually upgrade with. That path wiped the entire install directory before copying, so it deleted appsettings.local.json along with everything else -- see #45 and 98b5cfa. Correct-sounding guidance that does not hold on the real path is worse than none, because it stops people checking. Both places CLAUDE.md made the claim now say what is actually true, and note that the fix is not retroactive: a host on 0.6.3 or earlier still has the destructive installer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SQvL62WkT8xDWXqyjFCGDw
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAUDE.mdstated in two places thatappsettings.local.jsonsurvives a deploy. That was true ofdotnet publishand false ofinstall-service.ps1 -FromZip, which is the path people actually upgrade with — it wiped the entire install directory before copying, deleting the local file along with everything else.Fixed in
98b5cfa(#45 / #46), but the guidance needed correcting too. Correct-sounding advice that does not hold on the real path is worse than none, because it stops people checking.Both places now say what is actually true, name the commit that made it true, and note that the fix is not retroactive — a host on
0.6.3or earlier still has the destructive installer.Docs only; no code change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SQvL62WkT8xDWXqyjFCGDw