CADA RaceCar - support latest hw revision by vicocz · Pull Request #208 · vicocz/brickcontroller2

vicocz · 2026-03-07T15:04:15Z

Rework of #205

Copilot

Pull request overview

This PR aims to add support for the latest CaDA RaceCar hardware revision (Rev2) by extending CaDA device discovery and introducing an encoder abstraction for generating protocol-specific advertising payloads.

Changes:

Extend CaDA device scanning to recognize a new Rev2 manufacturer data format.
Introduce IMessageEncoder / factory + two encoder implementations (classic + Rev2) with unit tests.
Move CaDA registrations to the vendor-module pattern and broaden WinUI scan handling to include non-connectable advertisements.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
BrickController2/BrickController2/Protocols/CaDAProtocol.cs	Changes `Encrypt` to accept `Span<byte>` (call-site flexibility).
BrickController2/BrickController2/DeviceManagement/DI/DeviceManagementModule.cs	Removes direct CaDA registrations; relies on vendor modules for registration.
BrickController2/BrickController2/DeviceManagement/CaDA/RaceCarMessageEncoderRev2.cs	Adds Rev2 payload encoding logic (checksum/XOR + sequence handling).
BrickController2/BrickController2/DeviceManagement/CaDA/RaceCarMessageEncoder.cs	Adds classic payload encoding logic extracted into an encoder class.
BrickController2/BrickController2/DeviceManagement/CaDA/MessageEncoderFactory.cs	Adds a factory to choose the appropriate encoder based on device data length.
BrickController2/BrickController2/DeviceManagement/CaDA/IMessageEncoderFactory.cs	Introduces factory interface for encoder creation.
BrickController2/BrickController2/DeviceManagement/CaDA/IMessageEncoder.cs	Introduces encoder interface returning payload bytes to advertise.
BrickController2/BrickController2/DeviceManagement/CaDA/ICaDADeviceManager.cs	Adds CaDA-specific manager interface (exposes AppId).
BrickController2/BrickController2/DeviceManagement/CaDA/CaDARaceCar.cs	Minor visibility change; still contains classic telegram generation logic.
BrickController2/BrickController2/DeviceManagement/CaDA/CaDADeviceManager.cs	Adds Rev2 detection path and exposes AppId via `ICaDADeviceManager`.
BrickController2/BrickController2/DeviceManagement/CaDA/CaDA.cs	Registers CaDA devices/managers via the vendor module mechanism.
BrickController2/BrickController2.WinUI/Extensions/AdvertismentExtensions.cs	Allows processing non-connectable advertisements as data carriers.
BrickController2/BrickController2.Tests/DeviceManagement/CaDA/RaceCarMessageEncoderTests.cs	Adds unit tests for classic encoder behavior.
BrickController2/BrickController2.Tests/DeviceManagement/CaDA/RaceCarMessageEncoderRev2Tests.cs	Adds unit tests for Rev2 encoder behavior.
BrickController2/BrickController2.Tests/DeviceManagement/CaDA/PlatformService.cs	Adds test scaffolding for CaDA platform service behavior.
BrickController2/BrickController2.Tests/DeviceManagement/CaDA/MessageEncoderFactoryTests.cs	Adds unit tests for encoder selection based on device data size.
BrickController2/BrickController2.Tests/DeviceManagement/CaDA/CaDARaceCarTests.cs	Adds an (currently disabled) Rev2-oriented device test scaffold.
BrickController2/BrickController2.Tests/DeviceManagement/CaDA/CaDADeviceManagerTests.cs	Expands tests to cover Rev2 scan detection + AppId handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

BrickController2/BrickController2.Tests/DeviceManagement/CaDA/CaDARaceCarTests.cs

BrickController2/BrickController2/DeviceManagement/CaDA/CaDADeviceManager.cs

BrickController2/BrickController2/DeviceManagement/CaDA/RaceCarMessageEncoder.cs

BrickController2/BrickController2.Tests/DeviceManagement/CaDA/RaceCarMessageEncoderTests.cs

BrickController2/BrickController2/DeviceManagement/CaDA/CaDARaceCar.cs

BrickController2/BrickController2/DeviceManagement/CaDA/MessageEncoderFactory.cs

BrickController2/BrickController2/DeviceManagement/CaDA/RaceCarMessageEncoderRev2.cs

BrickController2/BrickController2/DeviceManagement/CaDA/RaceCarMessageEncoder.cs

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

BrickController2/BrickController2/DeviceManagement/CaDA/MessageEncoderFactory.cs

BrickController2/BrickController2.Tests/DeviceManagement/CaDA/CaDARaceCarTests.cs

...ntroller2/BrickController2.iOS/PlatformServices/DeviceManagement/CaDA/CaDAPlatformService.cs

BrickController2/BrickController2.Tests/DeviceManagement/CaDA/PlatformService.cs

Copilot · 2026-03-11T20:23:50Z

BrickController2/BrickController2/DeviceManagement/CaDA/CaDARaceCar.cs

+        //TODO var intValue = (int)(value * 0x7F); // scale and cast



Leftover //TODO in production code. Either remove it or implement the intended scaling/conversion (or add a clarifying comment that this is intentionally unused) to avoid shipping dead code markers.

Suggested change

//TODO var intValue = (int)(value * 0x7F); // scale and cast

Copilot · 2026-03-11T20:23:51Z

BrickController2/BrickController2/DeviceManagement/CaDA/CaDARaceCar.cs

+    protected internal bool TryGetTelegram(bool getConnectTelegram, out byte[] currentData)
    {
-        ushort random = (ushort)_rnd.Next(ushort.MinValue, ushort.MaxValue);
-
-        byte[] channelDataArray;
-
-        lock (_outputLock)
-        {
-            channelDataArray = new byte[]// 8
-            {
-                (byte)(random & 0xFF),
-                (byte)((random >> 8) & 0xFF),
-                (byte)Math.Max(0, Math.Min(0x80 - _outputValues[0], 0xFF)), // speed value - reversed
-                (byte)Math.Max(0, Math.Min(0x80 + _outputValues[1], 0xFF)), // 
-                (byte)Math.Max(0, Math.Min(0x80 + _outputValues[2], 0xFF)), // light on/off
-                0,
-                0,
-                0
-            };
-        }
-
-        CaDAProtocol.Encrypt(channelDataArray);
-
-        Array.Copy(channelDataArray, 0, _controlDataArray, 8, 8);
-
-        _controlDataArray[0] = 0x75; // 0x75 (117)
-        _controlDataArray[1] = 0x13; // 0x13 (19);
+        _outputValues.TryGetValues(out var outputValues);
+        currentData = _messageEncoder.Encode(outputValues, getConnectTelegram);

-        return _cadaPlatformService.TryGetRfPayload(_controlDataArray, out currentData);
+        return true;
    }


TryGetTelegram ignores the boolean returned by _outputValues.TryGetValues and always returns true. That bypasses OutputValuesGroup's change/resend signaling, and can cause UpdateAdvertisedDataAsync to run even when there is nothing new to apply (e.g., reconnect/connect-mode transitions). Consider returning getConnectTelegram || _outputValues.TryGetValues(...) (and only encoding when needed) so the handler can skip unnecessary updates.

BrickController2/BrickController2/DeviceManagement/CaDA/RaceCarMessageEncoder.cs

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

...ntroller2/BrickController2.iOS/PlatformServices/DeviceManagement/CaDA/CaDAPlatformService.cs

BrickController2/BrickController2.Tests/DeviceManagement/CaDA/PlatformService.cs

BrickController2/BrickController2.Tests/DeviceManagement/CaDA/CaDARaceCarTests.cs

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-11T21:38:32Z

BrickController2/BrickController2/DeviceManagement/CaDA/RaceCarMessageEncoderRev2.cs

@@ -0,0 +1,121 @@
+using System;
+
+using static System.Half; // for convenient usage of Half constants like 0.5h


The comment suggests Half literals like 0.5h, but C# doesn’t support an h literal suffix. Consider rewording this comment (or removing it) to avoid implying a non-existent syntax; the code already uses explicit (Half) casts.

Suggested change

using static System.Half; // for convenient usage of Half constants like 0.5h

using static System.Half; // for convenient usage of Half members and predefined constants

vicocz added 2 commits March 7, 2026 15:50

CADA RaceCar - support latest hw revision

600a318

Fix Windles BLE detection for non connectable devices

098664e

vicocz added the bug Something isn't working label Mar 7, 2026

vicocz added this to the 2026.1 milestone Mar 7, 2026

vicocz requested a review from Copilot March 7, 2026 15:04

Copilot started reviewing on behalf of vicocz March 7, 2026 15:05 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

vicocz and others added 3 commits March 7, 2026 18:15

Use message encoder factory for CADA Race Car - step 1

6384801

nit picks

89ed947

finetune + resolve comments from copilot

0bccd0e

vicocz requested a review from Copilot March 11, 2026 20:17

Copilot started reviewing on behalf of vicocz March 11, 2026 20:18 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

nitpicks

12e1245

vicocz requested a review from Copilot March 11, 2026 21:21

Copilot started reviewing on behalf of vicocz March 11, 2026 21:21 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

vicocz requested a review from Copilot March 11, 2026 21:29

Copilot started reviewing on behalf of vicocz March 11, 2026 21:30 View session

vicocz mentioned this pull request Mar 11, 2026

[bug] CADA RaceCar is not detected #204

Open

Copilot AI reviewed Mar 11, 2026

View reviewed changes

		//TODO var intValue = (int)(value * 0x7F); // scale and cast

		@@ -0,0 +1,121 @@
		using System;

		using static System.Half; // for convenient usage of Half constants like 0.5h

Conversation

vicocz commented Mar 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants