fix(goals): "ready to close" asks the number, not the task list (v0.456.1)

[vikasprogrammer]

The bug

A goal was offered for closing as soon as every task filed under it was done:

goalComplete = status === 'active' && progress.counted > 0 && progress.done === progress.counted

No reference to the metric. On the live instapods clicks goal that rendered a green "Ready to close" pill directly beside a metric panel reading "59 of 100 · Not moving" — the same page contradicting itself — and the scheduler's completion sweep had already carded the owner that the goal was finished while it was 41 clicks short.

The rule predates metrics, and its own comment is the argument against it: "all the filed tasks are done" is a weaker claim than "the outcome was achieved". Once a goal says what number it is about, the task list is the weakest evidence it has.

Fix

• GoalStore.readyToClose — and therefore Automations.sweepCompletedGoals, which reads it — excludes a goal with a metric unless metricStatus().verdict === 'achieved'.
• The console derives the same way (goalComplete now takes the metric status; the goals list already carries metrics on its payload).
• A goal with no metric is untouched — same behaviour as today.
• The quieter fact is still surfaced: a measured goal whose filed work ran out gets a muted note that the plan ran out before the number did, close it only if the outcome is good enough or plan the gap. Nobody having planned the rest is worth knowing; it just is not a close.

Testing

scripts/goal-metric-review-test.cjs grows a section pinning all four cases: no-metric goal still closes on tasks, a measured goal short of target is not offered, a measured goal at target is, and no "goal is finished" card is raised for the short one. Note the third case uses a direction: 'down' metric, so the guard is achieved, not value >= target. Full npm run test:governance passes; cd web && npm run build passes.

🤖 Generated with Claude Code