Repository navigation
fix(connectors): DataForSEO v2 reads DATAFORSEO_USERNAME (v0.459.1) - #866
Merged
Merged
Conversation
dataforseo-mcp-server@2.9.13 only reads DATAFORSEO_USERNAME, so the v2 catalog entry from 0.458.0 sent no login and got HTTP 401 on every call. The field now sets DATAFORSEO_USERNAME from the same secret:DATAFORSEO_LOGIN vault key; v3 reads DATAFORSEO_LOGIN and is unchanged. Test pins the per-version env var. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataforseo-mcp-server@2.9.13reads its login only fromDATAFORSEO_USERNAME; v3 readsDATAFORSEO_LOGIN(with a USERNAME fallback). The 0.458.0 v2 catalog entry setDATAFORSEO_LOGIN, so every v2 call returned HTTP 401.DATAFORSEO_USERNAME, still filled fromsecret:DATAFORSEO_LOGIN, so one vault key serves both versions.connector-auth-stub-test.cjspins the per-version env var.Verified against the real API: v2 with
DATAFORSEO_USERNAME→ status 20000; withDATAFORSEO_LOGIN→ 401.🤖 Generated with Claude Code