Repository navigation
Object model 5.8.0: light entities (LightType, LightSource, SunAndShadowSettings) (draft) - #62
Draft
SamuelAB-VIM wants to merge 3 commits into
Draft
SamuelAB-VIM wants to merge 3 commits into
SamuelAB-VIM wants to merge 3 commits into
Conversation
"light/lights.json" (one record per light source: element, world position and axes, emitter shape, distribution, intensity, colour temperature) and "light/<file>.ies" (IESNA LM-63 text). Without the type, ValidateAssets rejects such buffers. First user: the Revit exporter (vimaec/vimaec sam/exporter-lights). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s asset, experimental) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ntities Light data moves out of the JSON asset (light/lights.json, light/sun.json) into entity tables, so it merges like every other table (Martin, 2026-10-07). LightType relates to FamilyType (Revit keeps the light definition on the type) and to the IES file's asset row; LightSource relates to the fixture's Element and its LightType; SunAndShadowSettings relates to the exported View. Raw .ies files stay assets. Additions only; regenerated C#, TypeScript and C++; LightEntityTests round-trip and merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SamuelAB-VIM
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object model 5.8.0: LightType, LightSource and SunAndShadowSettings entities, related to FamilyType, Element and View (Martin's guidance: entity relations instead of JSON in the assets buffer). IES profiles stay as assets. Used by vimaec/vimaec#1176.
Early look - not fully QA'd yet. Sam will test and fix on Sunday.
🤖 Generated with Claude Code