Add fetchAppCheckToken prop to APIProvider#913
Merged
usefulthink merged 8 commits intovisgl:mainfrom Feb 6, 2026
Merged
Conversation
usefulthink
reviewed
Feb 4, 2026
Collaborator
usefulthink
left a comment
usefulthink
left a comment
There was a problem hiding this comment.
Awesome, thanks a lot for the PR!
Additionally, we need to update the documentation with some information about fetchAppCheckToken, but I can take care of that before merging.
| useEffect(() => { | ||
| if (status !== APILoadingStatus.LOADED) return; | ||
|
|
||
| if (fetchAppCheckToken) { |
Collaborator
There was a problem hiding this comment.
The if here prevents unsetting an existing fetchAppCheckToken setting.
That's likely not a regular occurrence, but always setting the value here shouldn't be an issue.
- Ensure `fetchAppCheckToken` is set or cleared correctly in `google.maps.Settings`. - Clarify comments to improve code readability.
…ith Firebase App Check
Collaborator
|
I just published a new prerelease including this change, stable release of 1.8.0 will probably be in the next week. Or use the release-tag: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan