Fix NavLink crash on undefined href for DocMeta items - #19
Closed
laugharn wants to merge 1 commit into
Closed
Conversation
…tems NavLink crashed with "Cannot read properties of undefined (reading 'startsWith')" when DocMeta items without an href property reached the component. Normalize href to "#" when falsy so startsWith and the Link component both receive a valid string. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@laugharn is attempting to deploy a commit to the birthstone Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Apr 6, 2026
Contributor
|
fixed in #22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cannot read properties of undefined (reading 'startsWith')whenDocMetaitems (which haveslugbut nohref) reached the component at runtimehrefto"#"when falsy, sostartsWithand the Next.jsLinkcomponent both receive a valid stringTest plan
SidebarSection.itemsincludesDocMetaentries🤖 Generated with Claude Code