fix: prevent out-of-workspace-root access for open-in-editor and open-in-file#255
Merged
antfu merged 2 commits intovitejs:mainfrom Mar 25, 2026
Merged
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
antfu
reviewed
Mar 24, 2026
| return { | ||
| handler: async (path: string) => { | ||
| await import('launch-editor').then(r => r.default(path)) | ||
| const resolved = resolve(context.cwd, path) |
Member
There was a problem hiding this comment.
It's better to be the workspace root instead of cwd, as users might want to open files from the monorepo. Use Vite's findWorkspaceRoot API
antfu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this PR won't allow user to open files outside of project directory for better security
Linked Issues
closes #254
Additional context