fix(core): toggle dock command entry instead of always switching#265
Merged
antfu merged 1 commit intovitejs:mainfrom Mar 25, 2026
Merged
fix(core): toggle dock command entry instead of always switching#265antfu merged 1 commit intovitejs:mainfrom
antfu merged 1 commit intovitejs:mainfrom
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change makes dock commands in the embedded client use
toggleEntry()instead of always callingswitchEntry(). Previously, running the same dock command twice would reopen or keep selecting the same dock instead of toggling it off. With this update, invoking the active dock command again clears the current selection, which makes command behavior more intuitive and consistent with a toggle action.Linked Issues
Additional context