Skip to content

fix(core): toggle dock command entry instead of always switching#265

Merged
antfu merged 1 commit intovitejs:mainfrom
SaKaNa-Y:fix/dock-command-toggle-entry
Mar 25, 2026
Merged

fix(core): toggle dock command entry instead of always switching#265
antfu merged 1 commit intovitejs:mainfrom
SaKaNa-Y:fix/dock-command-toggle-entry

Conversation

@SaKaNa-Y
Copy link
Copy Markdown
Contributor

Description

This change makes dock commands in the embedded client use toggleEntry() instead of always calling switchEntry(). Previously, running the same dock command twice would reopen or keep selecting the same dock instead of toggling it off. With this update, invoking the active dock command again clears the current selection, which makes command behavior more intuitive and consistent with a toggle action.

Linked Issues

Additional context

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 25, 2026

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@265

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@265

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@265

@vitejs/devtools-rpc

npm i https://pkg.pr.new/@vitejs/devtools-rpc@265

@vitejs/devtools-self-inspect

npm i https://pkg.pr.new/@vitejs/devtools-self-inspect@265

commit: 4851f99

@antfu antfu merged commit d690ee2 into vitejs:main Mar 25, 2026
6 checks passed
@SaKaNa-Y SaKaNa-Y deleted the fix/dock-command-toggle-entry branch March 26, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants