Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Reducing Threads #29

Merged
vitorhugo-java merged 2 commits into from
Feb 16, 2026
Merged

Reducing Threads #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdee1ca
Reduce thread pool size from 400 to 5
vitorhugo-java Feb 16, 2026
b2790be
Reduce thread pool size from 400 to 5
vitorhugo-java Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

private TypeReferenceModel typeReference;

private static final Logger log = LoggerFactory.getLogger(SerieControllerImpl.class);

Check notice on line 44 in src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Logger initialized with foreign class 

Logger initialized with foreign class `SerieControllerImpl.class`

Check notice on line 44 in src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Logger initialized with foreign class 

Logger initialized with foreign class `SerieControllerImpl.class`

@PostConstruct
private void init() {
Expand All @@ -61,7 +61,7 @@
MediaCategoryModel mediaMovieCategory = mediaCategoryService.findById(MOVIE_ID).orElseThrow(() -> new GenericException("Category not found"));
MediaCategoryModel mediaAnimeCategory = mediaCategoryService.findById(ANIME_MOVIE_ID).orElseThrow(() -> new GenericException("Category not found"));
MediaCategoryModel mediaUndefinedCategory = mediaCategoryService.findById(UNDEFINED_MEDIA_ID).orElseThrow(() -> new GenericException("Category not found"));
ExecutorService executorService = Executors.newFixedThreadPool(400);
ExecutorService executorService = Executors.newFixedThreadPool(5);

Check warning on line 64 in src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'ExecutorService' used without 'try'-with-resources statement

Check warning on line 64 in src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'ExecutorService' used without 'try'-with-resources statement
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing the thread pool from 400 to 5 threads may significantly impact performance if updateTitles() processes a large number of items concurrently. This 98.75% reduction in parallelism could create a bottleneck. Consider benchmarking this change or using a value based on available CPU cores (e.g., Runtime.getRuntime().availableProcessors()) to balance resource usage and throughput.

Suggested change
ExecutorService executorService = Executors.newFixedThreadPool(5);
int availableProcessors = Runtime.getRuntime().availableProcessors();
int poolSize = Math.max(5, availableProcessors * 2);
ExecutorService executorService = Executors.newFixedThreadPool(poolSize);

Copilot uses AI. Check for mistakes.

try {
var jsonArrayDailyExport = movieAPI.updateTitles();
Expand Down Expand Up @@ -98,7 +98,7 @@

media.setName(json.get("original_title").toString());

if (externalReferenceExisted.isPresent()) {

Check warning on line 101 in src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Constant values 

Condition `externalReferenceExisted.isPresent()` is always `false`

Check warning on line 101 in src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Constant values 

Condition `externalReferenceExisted.isPresent()` is always `false`
media.setId(externalReferenceExisted.get().getMedia().getId());
externalReference.setId(externalReferenceExisted.get().getId());
}
Expand All @@ -120,7 +120,7 @@
});
}
executorService.shutdown();
executorService.awaitTermination(Long.MAX_VALUE, TimeUnit.NANOSECONDS);

Check warning on line 123 in src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Result of method call ignored 

Result of `ExecutorService.awaitTermination()` is ignored

Check warning on line 123 in src/main/java/com/espacogeek/geek/data/impl/MovieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Result of method call ignored 

Result of `ExecutorService.awaitTermination()` is ignored

log.info("SUCCESS TO UPDATE movie, AT {}", LocalDateTime.now());
} catch (Exception e) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/espacogeek/geek/data/impl/SerieControllerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
MediaCategoryModel mediaSerieCategory = mediaCategoryService.findById(SERIE_ID).orElseThrow(() -> new GenericException("Category not found"));
MediaCategoryModel mediaAnimeCategory = mediaCategoryService.findById(ANIME_SERIE_ID).orElseThrow(() -> new GenericException("Category not found"));
MediaCategoryModel mediaUndefinedCategory = mediaCategoryService.findById(UNDEFINED_MEDIA_ID).orElseThrow(() -> new GenericException("Category not found"));
ExecutorService executorService = Executors.newFixedThreadPool(400);
ExecutorService executorService = Executors.newFixedThreadPool(5);

Check warning on line 65 in src/main/java/com/espacogeek/geek/data/impl/SerieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'ExecutorService' used without 'try'-with-resources statement

Check warning on line 65 in src/main/java/com/espacogeek/geek/data/impl/SerieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

AutoCloseable used without 'try'-with-resources 

'ExecutorService' used without 'try'-with-resources statement
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reducing the thread pool from 400 to 5 threads may significantly impact performance if updateTitles() processes a large number of items concurrently. This 98.75% reduction in parallelism could create a bottleneck. Consider benchmarking this change or using a value based on available CPU cores (e.g., Runtime.getRuntime().availableProcessors()) to balance resource usage and throughput.

Suggested change
ExecutorService executorService = Executors.newFixedThreadPool(5);
ExecutorService executorService = Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors());

Copilot uses AI. Check for mistakes.

try {
var jsonArrayDailyExport = tvSeriesApi.updateTitles();
Expand Down Expand Up @@ -96,7 +96,7 @@

media.setName(json.get("original_name").toString());

if (externalReferenceExisted.isPresent()) {

Check warning on line 99 in src/main/java/com/espacogeek/geek/data/impl/SerieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Constant values 

Condition `externalReferenceExisted.isPresent()` is always `false`

Check warning on line 99 in src/main/java/com/espacogeek/geek/data/impl/SerieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Constant values 

Condition `externalReferenceExisted.isPresent()` is always `false`
media.setId(externalReferenceExisted.get().getMedia().getId());
externalReference.setId(externalReferenceExisted.get().getId());
}
Expand All @@ -118,7 +118,7 @@
});
}
executorService.shutdown();
executorService.awaitTermination(Long.MAX_VALUE, TimeUnit.NANOSECONDS);

Check warning on line 121 in src/main/java/com/espacogeek/geek/data/impl/SerieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Result of method call ignored 

Result of `ExecutorService.awaitTermination()` is ignored

Check warning on line 121 in src/main/java/com/espacogeek/geek/data/impl/SerieControllerImpl.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Result of method call ignored 

Result of `ExecutorService.awaitTermination()` is ignored

log.info("SUCCESS TO UPDATE TV SERIES, AT {}", LocalDateTime.now());
} catch (Exception e) {
Expand Down
Loading