feat(yata): add SetAttrItem class for setting deleted, attrs, and targetIds #744
+784
−245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getIds - Add SetAttrItem class that can set: - deleted flag on any item - attrs on OpeningTagItem and NodeItem - targetId on OpeningTagItem and ClosingTagItem - Replace DeleteItem with SetAttrItem in replaceItemsInner for deletions - Add findSetAttrItemsByTargetId to Document for pending attribute lookup - Apply pending SetAttrItems when target item is integrated - Update forwardToDeletionEnd to skip SetAttrItems - Add comprehensive tests for SetAttrItem functionality https://claude.ai/code/session_01EPwA8AWwKymaWyzVTsks8p
…changes - Remove DeleteItem class entirely from item.ts - Remove DeleteItemJSON interface and 'delete' type from types.ts - Remove findDeleteItemByTargetId from Document - Update Item.putIntoDocument to only use SetAttrItem for pending changes - SetAttrItem with setDeleted: true now handles all deletion operations - Update tests to use SetAttrItem instead of DeleteItem - Simplifies the CRDT by having a single item type for attribute changes https://claude.ai/code/session_01EPwA8AWwKymaWyzVTsks8p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01EPwA8AWwKymaWyzVTsks8p