docs: document VMConfig thread-local isolation flake - #17
Closed
vividctrlalt wants to merge 3 commits into
Closed
Conversation
vividctrlalt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the root cause of intermittent
:framework:testfailures on Rocky Linux JDK 8 after tronprotocol#6857.The same commit is green on Debian 11 JDK 8, Ubuntu, and macOS. The failing cases are existing VM / backup / net tests. London and Osaka look off because
initAllowTvm*()writesglobalSnapshotwhilecurrent()prefers a leftover thread-local snapshot.Root cause
tronprotocol#6857 split VM config into a process-global snapshot (block processing) and a thread-local snapshot (constant calls). Getters use
current()(local if present).initAllowTvm*()still mutates only the global snapshot and was left for tests.ConfigLoader.disableskipsload(), so a leftover local view is never cleared. Tests that still callinit*therefore do not observe the flags they just set.VMConfigIsolationTestdoes not cover this contract. Pre-tronprotocol#6857 tests (AllowTvmLondonTestand others) were not migrated.Rocky Linux reproduces the race more often because the host is slower (
forkEvery = 100shares one JVM). A rerun going green is expected.Related
Closes nothing. Companion context: tronprotocol#6857.
Test plan
docs/rocky-ci-vmconfig-isolation.mdagainstVMConfig.java/ConfigLoader.java/ fix(vm): isolate constant-call config, self-dispatch vote-witness cost tronprotocol/java-tron#6857