Open
Conversation
Owner
|
This looks good. Could you re-push the PR? looks like there was an issue during build |
Maybe.Tap and Maybe.TapNoValue are able to take over the deprecated methods with added functionality.
Contributor
Author
|
@vkhorikov Is everything alright now? 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find the existing
Execute/ExecuteNoValueextensions a bit inconvenient, due to:Tapnomenclature (used inResultalready)voidreturn type prohibiting fluent method chaining.With
Executethe flow looks as follows:With the new
Tap, it could be:I also added
Obsoleteattribute toExecutesince I think it's not really needed whenTapis there. Please do let me know if that's alright.The new code is really just a copy of existing
Execute/ExecuteNoValuecode with added return functionality. Tests are also mostly copied.