Repository navigation
Start in a window by default, add -fullscreen flag - #209
xRookieFight wants to merge 1 commit into
Conversation
medvednikov
left a comment
medvednikov
left a comment
There was a problem hiding this comment.
Reviewed the startup flags, window dimensions, query layout, and session restoration at 3e36547. Two regressions in the new default behavior are noted inline. CI was excluded from this review.
| if !is_fullscreen { | ||
| win_width = 770 | ||
| win_height = 480 |
There was a problem hiding this comment.
[P2] Fit the query dialogs to the new default window
At the default line_height = 20, draw_query() gives Ctrl+P, Ctrl+J, and grep dialogs a fixed height of (20 + 2) * (20 + 5) + 15 = 565. In this 480-pixel window the dialog starts at y = -42, placing the query input at y = -22 completely above the visible area. Grep also retains a width of 1400, so its left edge is at x = -315. Opening the file finder or workspace search on a normal launch now hides the text being entered and clips results. Please make the dialogs/result limits fit the window, or choose dimensions that accommodate them.
| if !is_fullscreen || '-laptop' in args { | ||
| nr_splits = 1 |
There was a problem hiding this comment.
[P2] Preserve saved workspace assignments when changing the split count
An existing user who launches without arguments now gets one view per workspace instead of the previous two or three, but load_views() restores the flat session list by index. With workspaces A/B and saved views [A1, A2, A3, B1, B2, B3], the new two-element view array restores A1 into A and A2 into B, dropping every saved B view. open_file() also calls save_session() during restoration, so the old assignments are overwritten on that first launch. Please migrate/restore the saved views by workspace before reducing the default split count.
2 participants
Ved used to open fullscreen unless
-windowwas passed, so the less common mode was the default. It now starts in a 770x480 window, the same size the Super+Enter toggle returns to. Use-fullscreenfor the old behavior. The-windowflag is removed since the new default covers it. Windowed mode uses one split, same as before with-window.