Repository navigation
Use the V logo as window icon - #210
Open
xRookieFight wants to merge 1 commit into
Open
xRookieFight wants to merge 1 commit into
xRookieFight wants to merge 1 commit into
Conversation
medvednikov
reviewed
Oct 10, 2026
medvednikov
left a comment
medvednikov
left a comment
Member
There was a problem hiding this comment.
Reviewed d3e1ce0, including the embedded PNG, RGBA decoding, Sokol icon descriptor, fallback, and pixel lifetime through gg.new_context(). The 200x200 RGBA image and descriptor agree, and the retained pixel buffer remains available for Sokol's startup use. I found no actionable correctness issues in this change. This was a source/API review; I did not run the native window. CI was excluded from the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the V logo as the window icon. The PNG is embedded with
$embed_fileand decoded with stbi. If decoding fails, sokol's default icon is used.