Wipe the config directory of the e2e profile too - #107
Closed
vmillet-dev wants to merge 1 commit into
Closed
vmillet-dev wants to merge 1 commit into
vmillet-dev wants to merge 1 commit into
Conversation
tauri-plugin-window-state writes .window-state.json under app_config_dir(), which on Linux is not app_data_dir() — so the window geometry survived the wipe and a run opened on the window the previous one closed with. Windows cannot tell the two directories apart, which is why it passed there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Folded into #106 — one pull request for the e2e suite rather than two. The commit is cherry-picked there unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resetProfile()wipedapp_data_dir()and called the profile clean. Since#99 that is no longer the whole profile:
tauri-plugin-window-statewrites.window-state.jsonunderapp_config_dir(), and on Linux those are twodifferent directories —
~/.local/share/<id>against~/.config/<id>.So on Linux the window geometry survived every wipe, and a run opened on the
window the run before it closed with. Windows cannot tell the two apart —
both are
%APPDATA%\<id>— which is why the hole never showed there, and CInever met it either: its runners are new each time.
Both directories are wiped now, de-duplicated so Windows still does one pass,
and the "could not be wiped" guard names whichever one survived.
docs/architecture.mdsays so where it states the rule.The suite is 15/15 in 3:52 locally.
🤖 Generated with Claude Code