Say which platforms DevBox ships for, and stop implying macOS - #110
Merged
Merged
Conversation
The release and CI matrices build Windows and Linux only, but the bundle declared an .icns and the README named no platform at all. MacosLauncher stays: the autostart plugin takes it on every platform and ignores it off macOS, so it is a required argument rather than a dead branch. Commented as such. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
The release matrix builds
windows-latestandubuntu-22.04, the CI matrixtests the same two, and that is the whole list — but the repository did not say
so anywhere, and two things implied otherwise.
tauri.conf.jsonbundledicons/icon.icns. Gone, and the file with it.## Installby sayingWindows and Linux, and why there is no macOS build: nothing here can test it,
and Gatekeeper wants a paid Apple Developer account with no free bypass on
recent versions.
The decision is recorded in
docs/architecture.mdunder "Releasing", next to thematrices it constrains.
One correction to the ticket
The ticket lists
MacosLauncher::LaunchAgentinlib.rsas a macOS path "nevercompiled or tested", to be kept or dropped. It is neither: the autostart plugin
takes a
MacosLauncheron every platform and ignores it off macOS, so it isa required argument and removing it would not compile. It stays, commented as
such so the next reader does not file this again.
The one macOS mention that really was dead weight was a comment in
autostart.service.tsjustifying a read-back by macOS agent behaviour. The ruleholds on its own — the entry should not be rewritten on every start — so the
reasoning now says that instead.
Checked locally
npm test960 passing,npm run lintclean,cargo clippy --all-targets --all-features -D warningsclean,npm run e2e:buildbuilds without the icns,npm run test:e2e15/15 in 3:52.🤖 Generated with Claude Code