Skip to content

lightdm: deduplicate pam_elogind.so in PAM files.#61551

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
Closed

lightdm: deduplicate pam_elogind.so in PAM files.#61551
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 19, 2026

Copy link
Copy Markdown

Problem

The LightDM PAM files (lightdm, lightdm-greeter, lightdm-autologin) contain duplicate pam_elogind.so entries. The template post_install replaces pam_systemd.so with pam_elogind.so across all PAM files, which can create duplicate entries when source files already contain pam_elogind.so.

This causes errors during session transitions:

pam_elogind(lightdm-greeter:session): Failed to release session: No session 'c1' known

Fix

Add a targeted deduplication step in post_install using awk, applied only to pam_elogind.so lines in the three LightDM PAM files.

Testing

  • Built and tested on x86_64-glibc (Void Linux, runit)
  • Verified PAM files contain exactly one pam_elogind.so entry each
  • No more 'Failed to release session' errors in logs

@ghost

ghost commented Jul 19, 2026

Copy link
Copy Markdown
Author

Hi @classabbyamp, I saw this PR was closed with the AI 🤖 label and no explanation. I would like to understand the reason so I can address it properly.

If there is a technical issue with the patch, I am happy to fix it — just let me know what needs changing. I tested this on my daily driver (Void x86_64-glibc, runit, Cinnamon) and it resolves real Failed to release session errors that I was seeing on every greeter↔user transition. Before the fix, pam_elogind.so appeared twice in the LightDM PAM files; after the fix, exactly once.

If the concern is about AI-assisted contributions: I use AI as a drafting and research tool, but every line is reviewed, built in clean chroot, and tested on real hardware by me. The bug, the root cause, the fix, and the testing are all real. I stand behind the contribution.

That said, if Void has a policy against this kind of contribution I will respect it — I would just appreciate knowing clearly so I can adjust. Thanks for your time.

@classabbyamp

Copy link
Copy Markdown
Member

the fix you generated was incorrect, I implemented the correct fix in 05fdd1e.

Additionally, Void does have a policy against AI-generated contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant