Repository navigation
fix: isolate bundle rebuilds from the app token - #187
Merged
Merged
Conversation
fengmk2
added
the
needs-bundle-rebuild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/rebuild-bundle.ymlexposed a GitHub App token to PR code during dependency installation and bundle generation. That token could write repository contents.The build now runs on a separate runner with read-only access and no persisted credentials. A second job accepts only the three expected bundle files and treats their contents as data. It creates a token with
contents: writeonly after it checks the PR and the files. It commits through the GitHub API only if the branch still has the expected head commit. Unchanged bundles produce no commit.