Skip to content

fix: prevent Azure authEnv from controlling interpreter startup - #194

Closed
fengmk2 wants to merge 3 commits into
mainfrom
fix/azure-auth-env-safety
Closed

fengmk2 wants to merge 3 commits into
mainfrom
fix/azure-auth-env-safety

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Azure authEnv can set NODE_OPTIONS and run code before the setup runtime validates inputs.

The template now passes mappings under SETUP_VP_AUTH_ENV_. The runtime accepts credential names and rejects runtime settings and CI control variables before installation. It preserves secret values and treats unresolved Azure macros as missing credentials.

The template also preserves the original mapping as JSON metadata. The runtime rejects duplicate names even when Windows combines environment keys that differ only by case.

Custom names must use the credential forms listed in README.md. Existing secrets with other names can use a supported alias in authEnv and .npmrc.

@fengmk2

fengmk2 commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T15:56:42.059975Z f5b432f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b6edc6e0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/azure/auth-env.ts Outdated
@fengmk2
fengmk2 force-pushed the fix/azure-auth-env-safety branch from 7b6edc6 to f5b432f Compare October 10, 2026 15:36
@fengmk2

fengmk2 commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

@codex review

@fengmk2

fengmk2 commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

Too complicated, let's set it aside for now.

@fengmk2 fengmk2 closed this Oct 10, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: f5b432fdb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2
fengmk2 deleted the fix/azure-auth-env-safety branch October 10, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant