Open
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
|
@lyzno1 let's move packages/cli/snap-tests-todo/test-panicked-fix to packages/cli/snap-tests/test-panicked-fix 😄 |
lyzno1
force-pushed
the
codex/fix-help-pipe-panic
branch
from
3e8b606 to
40f5965
Compare
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fengmk2
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a CLI help path where
vp lint --helpandvp fmt --helpcould panic when stdout was closed early by a downstream pipe such ashead.Changes:
lintandfmtcommands before writing it back through the CLI.lint/fmthelp requests.--terminator.Validated with:
cargo test -p vite-plus-cli --libpnpm -F vite-plus snap-test-local test-panicked-fixpnpm -F vite-plus snap-test-local command-helper