Skip to content

fix(editor): Remove overrides from default config #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pweyck wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −2
Open

fix(editor): Remove overrides from default config #2357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/cli/src/utils/editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ const ZED_SETTINGS = {
settings: {
run: 'onType',
fixKind: 'safe_fix',
typeAware: true,
unusedDisableDirectives: 'deny',
},
Comment on lines 48 to 49

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep Zed type-aware for generated lint configs

For projects produced by the normal vp create/vp migrate path without a baseUrl, injectLintTypeCheckDefaults explicitly enables lint.options.typeAware, but the Oxlint language server does not consume the Vite+ lint block and now receives no corresponding typeAware initialization option. Consequently, Zed stops reporting the type-aware rules that vp lint runs, merely reversing the mismatch this change intends to prevent; the editor settings need to reflect the resolved project lint option rather than unconditionally dropping it.

Useful? React with 👍 / 👎.

Comment on lines 48 to 49

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove legacy overrides from existing Zed settings

When a project already has the .zed/settings.json written by an earlier Vite+ version, rerunning vp migrate --editor zed cannot apply this fix: writeEditorConfigs merges only missing keys and explicitly preserves every existing value, so the old typeAware: true and unusedDisableDirectives: "deny" entries remain indefinitely. Existing Zed users therefore retain the exact CLI/LSP mismatch this commit is intended to eliminate; the migration path needs targeted handling for these legacy generated values.

Useful? React with 👍 / 👎.

Comment on lines 48 to 49

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the documented Zed initialization settings

When users follow the manual Zed setup instead of generating the file, docs/guide/ide-integration.md lines 66-67 still instruct them to set both typeAware: true and unusedDisableDirectives: "deny". That path therefore recreates the exact CLI/language-server mismatch this removal is intended to prevent, so the documented configuration needs to be updated together with the generated defaults.

Useful? React with 👍 / 👎.

},
},
Expand Down
Loading