Skip to content

feat(cli): warn when project-local CLI is missing - #2362

Open
liangmiQwQ wants to merge 7 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/warn-missing-local-cli
Open

feat(cli): warn when project-local CLI is missing#2362
liangmiQwQ wants to merge 7 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/warn-missing-local-cli

Conversation

@liangmiQwQ

@liangmiQwQ liangmiQwQ commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Close #2361

This PR warns when vp delegates inside a project without a resolvable project-local vite-plus, while preserving the global CLI fallback.

  • If the project declares a vite-plus dependency, prompt the user to run vp install.
  • If the project does not declare a vite-plus dependency, direct the user to the migration guide.
  • If vp migrate is run, do not warn because it is the remediation path.
  • If the command runs outside a project, keep the existing silent fallback.

The vp exec RFC now distinguishes local-to-global CLI fallback from remote fallback for the command being executed.

🤖 Generated with Codex

@netlify

netlify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit a33485b
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a749e3983180e0008850fa8

@liangmiQwQ
liangmiQwQ force-pushed the liang/codex/warn-missing-local-cli branch 2 times, most recently from 3ed8a20 to 7c9b56c Compare August 6, 2026 13:19
@liangmiQwQ
liangmiQwQ force-pushed the liang/codex/warn-missing-local-cli branch from 7c9b56c to 5440075 Compare August 6, 2026 13:22
@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e21d37157

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vp_global_cli/src/js_executor.rs
Comment thread crates/vp_global_cli/src/commands/mod.rs Outdated
@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eeb4a77158

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vp_global_cli/src/commands/mod.rs Outdated
Comment thread crates/vp_global_cli/src/commands/mod.rs Outdated
@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da7e3cee99

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vp_global_cli/src/commands/mod.rs Outdated
@liangmiQwQ
liangmiQwQ marked this pull request as ready for review August 6, 2026 14:46
@liangmiQwQ
liangmiQwQ requested a review from fengmk2 August 7, 2026 04:14
@fengmk2

fengmk2 commented Aug 7, 2026

Copy link
Copy Markdown
Member

I recall a previous scenario where a project does not deps on vite-plus, but it uses the global vp CLI to install project dependencies.
Currently, would it be unreasonable for a prompt to appear in this situation?

@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@fengmk2 Direct vp install runs won't be delegated to local cli (as well as other PM commands), so they will not be affected here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RFC mismatch: fallback when missing local CLI

2 participants