chore(core): expose pluginutils export types - #2364
Open
jong-kyung wants to merge 2 commits into
Open
Conversation
Follow-up PR to voidzero-dev#2358: commit the regenerated package.json so the `./rolldown/pluginutils` exports regain their `types` conditions, which were dropped in voidzero-dev#1646 when upstream moved to `.mjs`.
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1828941d3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up PR to #2358.
That PR taught the sync tool to apply the
.mjsdeclaration mapping to pluginutils exports, but only changed the tool itself. This PR commits the regeneratedpackages/core/package.json, so the./rolldown/pluginutilsand
./rolldown/pluginutils/filterexports regain their explicittypesconditions.The
typesconditions were originally present but were dropped in #1646 when upstream@rolldown/pluginutilsmoved from.jsto.mjs, because the transformer at the time only mapped.jsdeclarations. Type resolutionstill worked in the meantime through TypeScript's adjacent-file lookup, since
index.d.mtsships next toindex.mjsindist/pluginutils, so this restores the explicit mapping rather than changing runtime behavior.