refactor(env): sort installed versions with node-semver - #2366
Open
jong-kyung wants to merge 1 commit into
Open
Conversation
Replace the hand-rolled compare_versions helper in env list with node_semver::Version, which is already a direct dependency of this crate. Unparseable directory names still sort first, and prerelease versions now order correctly per semver.
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jong-kyung
marked this pull request as ready for review
August 6, 2026 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vp env listsorted installed Node.js versions with a hand-rolledcompare_versionshelper, even thoughnode-semveris already a direct dependency of this crate and is used in nearby modules (upgrade_check.rs,doctor.rs,pin.rs).This replaces the helper with a single
sort_by_cached_keycall usingnode_semver::Version::parse.