Skip to content

test(snapshots): stop Windows network stalls from timing out PTY cases #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fengmk2 wants to merge 1 commit into from
+18 −0
Closed

test(snapshots): stop Windows network stalls from timing out PTY cases #2407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,12 @@ jobs:
run: |
"$HOME/.vite-plus/bin/vp" node --version \
|| echo "prewarm failed; cases will download the runtime on demand"
# Warm the Node.js version index cache (~1h TTL) into the runtime
# seed. Cases without a version pin resolve "latest LTS" before
# their first output, and a stalled nodejs.org fetch there times
# out the 60s step budget (same stall class as #2390).
"$HOME/.vite-plus/bin/vp" env list-remote > /dev/null \
|| echo "index prewarm failed; cases will fetch the version index on demand"

- name: Install Playwright Chromium
run: pnpm exec playwright install chromium
Expand Down Expand Up @@ -1059,6 +1065,12 @@ jobs:
run: |
"$USERPROFILE/.vite-plus/bin/vp.exe" node --version \
|| echo "prewarm failed; cases will download the runtime on demand"
# Warm the Node.js version index cache (~1h TTL) into the runtime
# seed. Cases without a version pin resolve "latest LTS" before
# their first output, and a stalled nodejs.org fetch there times
# out the 60s step budget (same stall class as #2390).
"$USERPROFILE/.vite-plus/bin/vp.exe" env list-remote > /dev/null \
|| echo "index prewarm failed; cases will fetch the version index on demand"

- name: Install Playwright Chromium
shell: bash
Expand Down
6 changes: 6 additions & 0 deletions crates/vp_cli_snapshots/tests/cli_snapshots/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,12 @@ impl CaseHome {
env.insert("TERM".into(), "xterm-256color".into());
env.insert("VP_CLI_TEST".into(), "1".into());
env.insert("NODE_NO_WARNINGS".into(), "1".into());
// Cap download attempts far below vp's 10-minute default: a stalled
// runtime or package-manager download must fail fast enough for vp's
// retry (3 attempts, exponential backoff) to finish inside the 60s
// step budget. Healthy CI downloads take ~1s; Windows runners stall
// intermittently (see command_cache_bun in the #2390 stall class).
env.insert("VP_DOWNLOAD_TIMEOUT".into(), "30".into());
env.insert("VP_HOME".into(), self.vp_home().into_os_string());
if cfg!(windows) {
env.insert("USERPROFILE".into(), self.home.clone().into_os_string());
Expand Down
Loading