Repository navigation
fix(create): skip react router git initialization - #3363
Merged
Merged
Conversation
Pass --no-git-init to create-react-router so its initial commit cannot abort Vite+ project integration when Git identity is not configured.
jong-kyung
approved these changes
Nov 5, 2026
Member
|
@chbaefront Can you add a snapshot test to coverage this bug fix? |
Contributor
Author
|
@fengmk2 Added a CLI snapshot regression test using create-react-router@8.5.1 with a local template and no Git identity configured. Verified that the test fails with the original Git initialization error when the fix is removed, and passes with --no-git-init, including successful Vite+ integration. |
fengmk2
approved these changes
Nov 6, 2026
chbaefront
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3362
Pass --no-git-init to create-react-router so its initial commit cannot abort Vite+ project integration when Git identity is not configured.
Closes #3362