Skip to content

Feature/wiki link#2558

Open
fujiajie666 wants to merge 11 commits into
volcengine:mainfrom
fujiajie666:feature/wiki-link
Open

Feature/wiki link#2558
fujiajie666 wants to merge 11 commits into
volcengine:mainfrom
fujiajie666:feature/wiki-link

Conversation

@fujiajie666

Copy link
Copy Markdown
Collaborator

Description

This PR adds resource-memory linking support and improves memory overview consistency for resource lifecycle operations. Resource uploads, content writes, and resource deletion can now preserve or clean up related memory references through MEMORY_FIELDS.resource_refs, while keeping visible memory content readable and keeping memory directory .overview.md files in sync.

Related Issue

N/A

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • Added resource-to-memory linking for uploaded resources by extracting durable memory entries from add-resource reasons and storing resource references in MEMORY_FIELDS.resource_refs.
  • Added resource URI handling for memory writes, including Markdown resource link detection, bare resource URI linkification, resource_refs synchronization, memory overview refresh, and memory embedding refresh without generating .abstract.md.
  • Updated resource deletion flow to clean up resource references from related memories, support recursive resource URI cleanup, refresh affected memory directory .overview.md files, and expose cleanup / semantic refresh status in API responses.
  • Added ov rm --wait / timeout plumbing through CLI and clients so callers can wait for queued resource-side semantic refresh when needed.
  • Updated English and Chinese API docs for resource reference cleanup, write behavior, and filesystem remove behavior.
  • Added tests for resource-memory linking, content write resource refs, filesystem remove overview refresh, router response fields, wait tracking, and link rendering behavior.

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Test commands run locally:

uv run pytest tests/service/test_fs_service.py tests/server/test_filesystem_router.py tests/service/test_resource_memory_link_service.py tests/server/test_content_write_service.py tests/test_link_renderer.py -q

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🏅 Score: 85
🧪 PR contains tests
🔒 No security concerns identified
✅ No TODO sections
🔀 Multiple PR themes

Sub-PR theme: Add resource-memory linking service

Relevant files:

  • openviking/service/resource_memory_link_service.py
  • tests/service/test_resource_memory_link_service.py
  • openviking/prompts/templates/processing/resource_linking.yaml
  • openviking/prompts/templates/processing/resource_unlinking.yaml

Sub-PR theme: Update content write for resource refs and overview refresh

Relevant files:

  • openviking/storage/content_write.py
  • tests/server/test_content_write_service.py
  • openviking/session/memory/memory_updater.py

Sub-PR theme: Update API documentation

Relevant files:

  • docs/en/api/02-resources.md
  • docs/zh/api/02-resources.md
  • docs/en/api/03-filesystem.md
  • docs/zh/api/03-filesystem.md

⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@fujiajie666 fujiajie666 requested a review from MaojiaSheng June 11, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants