You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR is the second in a stacked series and focuses on recall trace core functionality, building on the tool allowlist/blocklist changes from the first PR.
Non-compliant requirements:
N/A (this PR is focused on recall trace core, not the original ticket requirements)
The warnings array in RecallTraceJsonlStore accumulates all warnings indefinitely and is never cleared. This can lead to unbounded memory growth over time, and repeated flush/query calls will return duplicate warnings.
The pending array in RecallTraceJsonlStore retains all past append promises unless flush() is called. If flush() is not called regularly, this can lead to unnecessary memory retention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Stacked PR plan: this is PR 2/5, based on #2566.