Skip to content

rfc1002 rustforge.tar-> rf#43

Merged
IGN-Styly merged 1 commit intomainfrom
t3code/f6ac4caa
Mar 12, 2026
Merged

rfc1002 rustforge.tar-> rf#43
IGN-Styly merged 1 commit intomainfrom
t3code/f6ac4caa

Conversation

@IGN-Styly
Copy link
Member

@IGN-Styly IGN-Styly commented Mar 12, 2026

Summary by CodeRabbit

  • New Features

    • Introduced the .rf mod package format as the standard for mod packaging and discovery.
    • Added strict mode version compatibility checks, controllable via environment variable.
    • Updated mod loading with platform-specific support.
  • Documentation

    • Added RFC 1002 documenting the Rustforge Mod Package Format specification, including packaging requirements and safety constraints.

@IGN-Styly IGN-Styly merged commit 1ccb478 into main Mar 12, 2026
5 of 6 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4407550b-4f1d-4f12-8bf5-3b4446cab9b7

📥 Commits

Reviewing files that changed from the base of the PR and between f9ddcc8 and 594fb1e.

📒 Files selected for processing (2)
  • enginelib/src/plugin.rs
  • rfc/rfc1002.md

📝 Walkthrough

Walkthrough

The changes implement the Rustforge Mod Package Format (.rf), updating module scanning to accept only .rf-extension files, adjusting platform-specific library naming (mod.dylib for macOS, mod.so for other Unix), and making version compatibility checks conditional on the GE_STRICT_MODS environment variable.

Changes

Cohort / File(s) Summary
Module scanning and loading logic
enginelib/src/plugin.rs
Updated to scan for .rf files exclusively instead of tar archives with rustforge stem verification; added macOS-specific mod.dylib dynamic library naming; made version compatibility errors conditional on GE_STRICT_MODS environment variable.
Format specification
rfc/rfc1002.md
New RFC document defining the .rf mod package format, including archive structure, platform-specific library files, ABI exports, safety constraints, and version compatibility behavior controlled by GE_STRICT_MODS.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 With whiskers twitched and joy so bright,
We scan for .rf files with delight!
No more tar trails, just clean and neat,
macOS gets dylib—oh how sweet!
Our strict mode watches when it must,
A modular future built on trust! 🎉

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch t3code/f6ac4caa

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant