Canonicalize chunked nested types through the builder [builders-child-stack] - #8967
Open
robert3005 wants to merge 1 commit into
Open
Conversation
Merging this PR will regress 10 benchmarks
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
This was referenced Jul 25, 2026
Closed
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
2 times, most recently
from
July 29, 2026 07:35
afed52f to
79f350a
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
2 times, most recently
from
July 29, 2026 14:19
1145029 to
8f39b06
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
July 31, 2026 13:35
8f39b06 to
825ab2e
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
July 31, 2026 15:29
825ab2e to
ce2eb1d
Compare
robert3005
commented
Jul 31, 2026
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
July 31, 2026 16:54
ce2eb1d to
cefbc8e
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
July 31, 2026 17:22
cefbc8e to
0d4eb9a
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
July 31, 2026 18:39
0d4eb9a to
1e8346a
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
July 31, 2026 18:43
1e8346a to
0431fa7
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
2 times, most recently
from
July 31, 2026 22:45
a9f7d31 to
9c8574c
Compare
robert3005
changed the base branch from
claude/builders-lazy-validity-9ze0t6
to
claude/constant-fast-paths-9ze0t6
July 31, 2026 22:47
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
August 1, 2026 09:43
9c8574c to
0b003e4
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
2 times, most recently
from
August 5, 2026 12:51
876aa4e to
a66422f
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
August 7, 2026 10:40
a66422f to
dac04cb
Compare
robert3005
changed the base branch from
claude/constant-fast-paths-9ze0t6
to
claude/builders-bulk-loop-callers-9ze0t6
August 7, 2026 11:09
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
August 7, 2026 11:14
dac04cb to
3f93504
Compare
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
August 7, 2026 13:10
3f93504 to
697f31a
Compare
`pack_struct_chunks`, `swizzle_fixed_size_list_chunks` and `swizzle_list_chunks` existed because `append_to_builder` used to decode a builder's children: without them, canonicalizing a `ChunkedArray` would concatenate every chunk's children instead of reusing them. Their doc comments describe what the builders now do on their own, so all three are dead weight - the generic builder path produces the same swizzled array, with each chunk's children kept as chunks of the combined child. Only `Variant` still needs a hand-written pack, because there is no variant builder. This drops the one canonicalization path that allocated its buffers through the session allocator: `swizzle_list_chunks` allocated its offsets and sizes with `ctx.allocator()`, whereas `builder_with_capacity_in` still ignores the allocator it is handed, so chunked primitives, structs and FSLs already went around it. `list_canonicalize_uses_memory_session_allocator` guarded that one path and goes with it; restoring the property means teaching the builders to allocate through a `HostAllocatorRef`, not keeping a bespoke list swizzle alive. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Robert Kruszewski <robert@spiraldb.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
robert3005
force-pushed
the
claude/chunked-canonical-via-builder-9ze0t6
branch
from
August 7, 2026 14:36
697f31a to
5f173bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always use builders when canonicalizing chunked arrays