feat(array): cast bool and primitive values to Utf8 - #9261
Open
haohuaijin wants to merge 4 commits into
Open
Conversation
haohuaijin
force-pushed
the
codex/bool-primitive-to-utf8
branch
from
August 7, 2026 06:19
36c6f4f to
ff0d6f9
Compare
haohuaijin
marked this pull request as ready for review
August 7, 2026 07:39
Signed-off-by: Huaijin <haohuaijin@gmail.com>
…r path Signed-off-by: Huaijin <haohuaijin@gmail.com>
Signed-off-by: Huaijin <haohuaijin@gmail.com>
Drop the TestResult alias and inline crate::Canonical qualifications in the primitive cast tests, move to_bit_buffer out of the all-null bool cast path, and cover f16 NaN/inf formatting in the array-path utf8 cast. Signed-off-by: Huaijin <haohuaijin@gmail.com>
haohuaijin
force-pushed
the
codex/bool-primitive-to-utf8
branch
from
August 8, 2026 02:42
db1e564 to
d12b54a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
DataFusion can push
CAST(... AS STRING)into Vortex scans, but boolean and primitive arrays currently lack native casts toUtf8, causing pushed queries to fail with a missingCastKernel.Related to #6211, #8621, and #6702.
What changes are included in this PR?
BoolArray -> Utf8andPrimitiveArray -> Utf8casts.Bool -> Primitive.Validation:
cargo nextest run -p vortex-arraycargo nextest run -p vortex-datafusionCAST(... AS STRING)with projection pushdown enabled, and verifies both values and nulls.developwith a missingBool -> Utf8cast kernel and passes with this PR.cargo clippy -p vortex-datafusion --all-targets --all-featurescargo +nightly fmt --allWhat APIs are changed? Are there any user-facing changes?
No public API signatures are changed.
Boolean and primitive values can now be cast to
Utf8inside Vortex, including DataFusion projection pushdown.