Allow omitting sum from default zone stats - #9296
Draft
gatesn wants to merge 1 commit into
Draft
Conversation
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Merging this PR will degrade performance by 45.69%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The SQL-style Sum partial introduced in #9113 is a struct. Readers released before that change ignore the new aggregate option, infer the historical scalar Sum partial, and cannot deserialize newly written zone maps. Downstream systems with a forward-compatibility contract need a way to retain the new runtime Sum semantics while temporarily omitting the incompatible persisted optimization.
This option affects only default zone statistics. Explicit
aggregate_fnsremain authoritative, and data values and query-time Sum behavior are unchanged.Validation
cargo +nightly fmt --allcargo test -p vortex-layout default_aggregates --all-featurescargo check -p vortex-file --all-featurescargo clippy -p vortex-layout -p vortex-file --all-targets --all-featuresAuthored by Codex on behalf of Nicholas Gates.