Optimise min/max computation for VarBinView arrays - #9740
robert3005 wants to merge 5 commits into
Performance Regression: -17.14%
⚠️ Unknown Walltime execution environment detected
Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.
For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.
⚠️ 3 benchmarks measured no execution time
Nothing ran under measurement, usually because the compiler removed the code under test. These results are not comparable, so they count as unchanged.
❌ 5 regressed benchmarks
✅ 2175 untouched benchmarks
🆕 6 new benchmarks
⏩ 385 skipped benchmarks1
Warning
Please fix the performance issues or acknowledge them on CodSpeed.
Performance Changes
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | WallTime | mul_u64_nonnull_neon |
29.2 µs | 39.8 µs | -26.59% |
| ❌ | WallTime | mul_i64_nonnull_neon |
33 µs | 38.9 µs | -14.99% |
| ❌ | WallTime | multiply_shapes_neon[(32768, PerRowPerRow)] |
33 µs | 38.8 µs | -14.84% |
| ❌ | WallTime | filtered_sink_i64_avx2[OneNullInEight] |
22.1 µs | 25.9 µs | -14.74% |
| ❌ | WallTime | filtered_owned_i64_avx512[OneNullInEight] |
22.5 µs | 26.1 µs | -13.81% |
| 🆕 | Simulation | max_utf8_view_distinct_prefixes |
N/A | 139.2 µs | N/A |
| 🆕 | Simulation | max_utf8_view_low_cardinality |
N/A | 206 µs | N/A |
| 🆕 | Simulation | max_utf8_view_nulls_scattered |
N/A | 375.6 µs | N/A |
| 🆕 | Simulation | max_utf8_view_shared_prefix |
N/A | 651.6 µs | N/A |
| 🆕 | Simulation | max_utf8_view_tied_prefix_inlined |
N/A | 387 µs | N/A |
| 🆕 | Simulation | max_utf8_view_tied_prefix_outlined |
N/A | 535.4 µs | N/A |
| Simulation | fixed_16_advancing_ptr_safe[100] |
< 1 ns | < 1 ns | N/A | |
| Simulation | preverify_advancing_ptr_unchecked[1000] |
< 1 ns | < 1 ns | N/A | |
| Simulation | preverify_advancing_ptr_unchecked[10000] |
< 1 ns | < 1 ns | N/A |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/varbin-compute-min-max-refactor-xvijwu (200c0ea) with develop (38fa7e3)2
Footnotes
-
385 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
develop(53f6dbb) during the generation of this report, so 38fa7e3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩