feat(cuda): support column projection and dictionary decoding in file scans - #9934
Conversation
Merging this PR will regress 1 benchmark
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | take_fsl_u32_random[256, 10] |
124.4 µs | 162.3 µs | -23.33% |
| ⚡ | Simulation | take_fsl_u32_random[16, 100] |
165.8 µs | 126 µs | +31.64% |
| ⚡ | Simulation | take_fsl_nullable_random[16, 100] |
187.6 µs | 165.4 µs | +13.41% |
| ⚡ | Simulation | take_fsl_f16_random[256, 100] |
231.8 µs | 204.8 µs | +13.18% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ad/cuda-projected-file-scans (39ddfa5) with develop (5c1671e)
Footnotes
-
251 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
1 benchmark was run, but is now archived. If it was deleted in another branch, consider rebasing to remove it from the report. Instead if it was added back, click here to restore it. ↩
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
cada5a9 to
744abf1
Compare
|
@claude review |
|
Claude finished @robert3005's task in 2m 49s —— View job Claude PR Review
Reviewed against Correctness / design notes1.
Writing into the source tree from a build script is also generally discouraged (cargo expects build output in 2. CUDA edition registration (
The concurrency test ( 3. Smaller observations
Not blocking
Overall this looks solid and is already approved. The main thing I'd double-check before merge is item #1 (generated-header |
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
… in CI Address review item 4. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 5. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 7. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 11. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 10. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 12. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 13. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 15. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 8. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 3. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 2. Restore the pre-PR RowCount policy rather than silently subdividing layout spans evenly. Add exact-size and cross-layout host regressions plus GPU coverage for splitting a single block. General CUDA Chunked concatenation remains a documented pre-existing limitation. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 9. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 1. Keep per-block IntDict compression when disabling outer layout dictionaries; move and strengthen writer regressions alongside layout tests. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 6. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Address review item 14. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Summary