Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions docs/_static/versioning-checks.svg

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not make this from a markdown system?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its a bit hard, and not sure what is wrong with an svg

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
127 changes: 127 additions & 0 deletions docs/_static/versioning-compatibility.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
72 changes: 72 additions & 0 deletions docs/_static/versioning-flow.svg
Comment thread
connortsui20 marked this conversation as resolved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this diagram is a bit misrepresentative and the bottom text is irrelevant

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to have something that differentiates original encoding to revved encoding. Vertical partition in diagram maybe.

Something like

DBP array (1 child, doesn't support 128 and 256) <- serde -> decimal_byte_parts serialized

                                                                             | Encoding update

DBP array (1 - 4 children, supports 128 and 256) <- serde -> decimal_byte_parts serialized (v1) OR decimal_byte_parts serialized (v2)

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions docs/_theme/vortex/vortex.css
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,10 @@ table.docutils th, table.docutils td {
}
table.docutils th { background: var(--bg-alt); }

table.versioning-terms p { margin: 0; }
table.versioning-terms td:first-child { white-space: nowrap; }
figure.versioning-diagram { margin-inline: 0; }

.page-index .content > section > h1 {
position: absolute;
width: 1px; height: 1px;
Expand Down
Loading
Loading