rewrite the implementation to not rely on context updates but use subscriptions instead #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut use subscription instead Move most of the logic of managing a focusable tree node into the FocusableNode class
Changes the public API of the library BREAKING CHANGE: SunbeamProvider -> Root
Change the public API BREAKING CHANGE: useSunbeam -> useFocusManager
vovacodes
force-pushed
the
feature/subscription-instead-of-context
branch
from
0ee305f to
8c7ea2c
Compare
vovacodes
force-pushed
the
feature/subscription-instead-of-context
branch
from
8c7ea2c to
8df5ff5
Compare
vovacodes
force-pushed
the
feature/subscription-instead-of-context
branch
from
4b6031d to
04d0094
Compare
vovacodes
force-pushed
the
feature/subscription-instead-of-context
branch
3 times, most recently
from
23a4e7e to
f3b2a05
Compare
vovacodes
force-pushed
the
feature/subscription-instead-of-context
branch
from
f3b2a05 to
031b2a2
Compare
vovacodes
force-pushed
the
feature/subscription-instead-of-context
branch
from
f455870 to
5ffc39b
Compare
vovacodes
force-pushed
the
feature/subscription-instead-of-context
branch
from
5ffc39b to
a1cb76e
Compare
Add support for keyup listeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move most of the logic of managing a focusable tree node into the FocusableNode class
This is still WIP, I'm trying to polish the API and need to add a couple of tests, marked as todo now.