Hol functional extensionality#874
Merged
Merged
Conversation
…lution, options and unit tests
quickbeam123
approved these changes
Jul 1, 2026
MichaelRawson
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding functional extensionality to HOL, that can be enabled by
func_ext=abstraction. The option was already there but didn't do anything until now. I switched the default option toofffor now, as abstraction gives slightly fewer proofs on THX problems. First-order benchmarks are unaffected by the change.We should later probably also do this for variable sorts, as well as Booleans (= Boolean extensionality), but I wasn't sure if those cases can be safely covered currently.
THX with
func_ext=abstraction:Discount:
master unsat: 2147 (77) sat: 1 (0) cputime: 9545.21 s instructions: 49204782 Mi memory: 136339.48 MB
branch unsat: 2136 (66) sat: 1 (0) cputime: 9729.12 s instructions: 49982726 Mi memory: 139925.18 MB
Otter:
master unsat: 2126 (70) sat: 1 (0) cputime: 9863.07 s instructions: 49617558 Mi memory: 180796.81 MB
branch unsat: 2121 (65) sat: 1 (0) cputime: 10025.58 s instructions: 50147647 Mi memory: 182001.22 MB
Note that ~30 problems switched from
INCOMPLETEto being solved.