Chore/improve locale framework - #14
Draft
chriscross12324 wants to merge 12 commits into
Draft
Conversation
…ing new key/file structure.
…ork with new folder/file structure (Still supports previous method where each language is a single file).
… for General, Sync, and Maintenance setting pages.
…dded additional translations.
…n strings related to dialogs, including action buttons that are specific to a dialog.
…_maintenance.json.
…cket (Minio, S3, R2) options.
Owner
|
Thank you very much for this contribution. While preparing v1.0.0, we changed the project boundary: application translations and dialogues now live in the main Self-hosted LiveSync repository, while Commonlib keeps its canonical English service messages and translation-injection boundary. This should make future contributions easier to locate, understand, and merge. I am sorry to ask for additional work after you prepared this PR. Would you be willing to open a new PR against Self-hosted LiveSync using the current structure? Thank you again for your contribution and patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT
The focus of this PR will be migrating from a single JSON file per language to multiple files per language.
Rather than having a single JSON file hundreds of lines long, this PR will work on migrating to multiple JSON files. This change will improve readability, sorting messages by the settings page they are found in. As a result, this will also improve maintainability.
Current
common/
├─ messagesJson/
│ ├─ de.json
│ ├─ en.json
│ ├─ es.json
│ ├─ ja.json
│ ├─ ko.json
│ ├─ ru.json
│ ├─ zh-tw.json
│ ├─ zh.json
Proposed
common/
├─ locales/
│ ├─ template/
│ │ ├─ actions.json
│ │ ├─ page_getting_started.json
│ │ ├─ page_general.json
│ │ ├─ page_remote.json
│ │ ├─ page_sync.json
│ │ ├─ page_maintenance.json
│ │ ├─ page_about.json
│ ├─ en/
│ ├─ es/
│ ├─ [...]/