Skip to content

refactor(i18n): update dictionary with source-based keys and Spanish translations - #69

Open
zeedif wants to merge 1 commit into
vrtmrz:mainfrom
zeedif:refactor/i18n-source-keys-dictionary
Open

refactor(i18n): update dictionary with source-based keys and Spanish translations#69
zeedif wants to merge 1 commit into
vrtmrz:mainfrom
zeedif:refactor/i18n-source-keys-dictionary

Conversation

@zeedif

@zeedif zeedif commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
  • Restructured combinedMessages.prod.ts to use natural English source strings as primary localization keys, removing the deprecated dot-notation identifier pattern.
  • Extracted hardcoded UI text from library components into the $msg localization system.
  • Added comprehensive Spanish (es) translations for all newly migrated and extracted entries, keeping only def and es for new items.

Note: This update acts as the foundational dictionary support for the comprehensive UI i18n migration in the main obsidian-livesync repository.

…translations

- Restructured `combinedMessages.prod.ts` to use natural English source strings as primary localization keys, removing the deprecated dot-notation identifier pattern.
- Extracted hardcoded UI text from library components into the `$msg` localization system.
- Added comprehensive Spanish (`es`) translations for all newly migrated and extracted entries, keeping only `def` and `es` for new items.

Note: This update acts as the foundational dictionary support for the comprehensive UI i18n migration in the main `obsidian-livesync` repository.
@zeedif

zeedif commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

It looks like tsc-check is tripping up because this PR goes hand-in-hand with the i18n changes in the main obsidian-livesync repo. I've tested both updated repos together locally, and tsc-check passes perfectly with 0 errors.

@vrtmrz

vrtmrz commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Thank you very much for this contribution.

While preparing v1.0.0, we changed the project boundary: application translations and dialogues now live in the main Self-hosted LiveSync repository, while Commonlib keeps its canonical English service messages and translation-injection boundary. This should make future contributions easier to locate, understand, and merge.

I am sorry to ask for additional work after you prepared this PR. Would you be willing to open a new PR against Self-hosted LiveSync using the current structure? Thank you again for your contribution and patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants