feat: dont rely on sellerName when creating a request

[ghost]

What problem is this solving?

Rely only on the sellerId to link a product to a seller. The solution was to get the seller name when resolving the objects that serve it to the front end.

How to test it?

Workspace

The requestId provided here is useful for testing because the sellerName was saved as an empty string. If you look for the sellerName on the graphqlIDE you should see the correct sellerName

{
  returnRequest(requestId: "1eed2aae-2399-11ed-835d-0e0377f22cbd") {
    items {
      sellerName
    }
  }
}

[vtex-io-ci-cd]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

• Patch (backwards-compatible bug fixes)

• Minor (backwards-compatible functionality)

• Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

• No thanks, I would rather do it manually 😞

[vtex-io-docs-bot]

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

• There's nothing new to document 🤔
• I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

• I just updated 🎉🎉

[filafb]

Sorry for taking this long to review. I added a couple of questions / change requests. I mentioned a endpoint @cesarocampov mentioned to me, but I am not familiar with it. I am suggesting this because I am not sure if the seller name inside the order gets updated when it changes. Not sure how to test it, but we should try to test it. And if we go down the route to use this endpoint, we need to understand what it returns if an account is no longer a seller in a marketplace. It's worth discussing it.

[filafb]

Please rebase and make sure changelog is right. The changes listed above are already released.

[filafb]

Since we are resolving it before sending the response, we can keep it as non-nullable.

It's important to note that when you change something on GraphQL (also routes on node), depending on the changes we get a warning in the terminal like the below one. If we proceed with these change, we would have to release a new major.

[filafb]

We don't need to make it null as well. The field is not listed as a required one, so it can be undefined.

[filafb]

We don't need to make another request to get the request. It is passed into this function as root, hence the type it has. Moreover, not sure the order should be the source of truth here. @cesarocampov told me about a endpoint that brings the seller name giving the seller id.