Repository navigation
docs: add NVD API 2.0 compatibility examples and tests - #214
Merged
Merged
Conversation
Covers the NvdApi client added in 0.1.4: a README section with sync and async examples that look up a CVE and page through a date range with cursor, plus sync and async integration tests for all five endpoints and the cursor walk.
alex-vulncheck
force-pushed
the
4164-nvd-compat-examples
branch
from
October 13, 2026 09:50
3639abb to
4e1de3c
Compare
robc-vulncheck
previously approved these changes
Oct 13, 2026
robc-vulncheck
left a comment
robc-vulncheck
left a comment
Collaborator
There was a problem hiding this comment.
approved, just a few minor suggestions above, mainly to match the go sdk
Co-authored-by: robc-vulncheck <309769615+robc-vulncheck@users.noreply.github.com>
Co-authored-by: robc-vulncheck <309769615+robc-vulncheck@users.noreply.github.com>
Co-authored-by: robc-vulncheck <309769615+robc-vulncheck@users.noreply.github.com>
Co-authored-by: robc-vulncheck <309769615+robc-vulncheck@users.noreply.github.com>
Co-authored-by: robc-vulncheck <309769615+robc-vulncheck@users.noreply.github.com>
Co-authored-by: robc-vulncheck <309769615+robc-vulncheck@users.noreply.github.com>
alex-vulncheck
enabled auto-merge (squash)
October 13, 2026 11:06
robc-vulncheck
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents and tests the
NvdApiclient added in 0.1.4. It covers the NVD API 2.0 compatible endpoints under/rest/json, which work with any VulnCheck API token, including community.Changes
tests/nvd.py/tests/nvd_aio.py: sync and async examples that look upCVE-2021-44228, then page through a one-daylast_modrange withcursor. Sending an empty cursor opts in, and the loop stops whennext_cursorisNone.<details>block, regenerated withcog. The README diff only adds lines.tests/integration_test.py: tests for all five endpoints plus a two-page cursor walk.tests/integration_aio.py: the same checks for the async client, added to itsmain().tests/readme_examples_test.py: runs both new examples.There are no changes under
vulncheck_sdk/, so merging this doesn't trigger a release.Testing (against
api.vulncheck.com)pytest tests/: 44 passed, including the 6 new NVD tests, both new examples, and the async integration suite run via the example harness.make lint: the flake8 error check is clean.