WIP: adding resize#48
Open
casibbald wants to merge 1 commit into
Open
Conversation
spelltasticsoup
force-pushed
the
feature/add-Container-tty-resize
branch
5 times, most recently
from
696a7d1 to
43fa6f1
Compare
spelltasticsoup
force-pushed
the
feature/add-Container-tty-resize
branch
from
43fa6f1 to
127c94f
Compare
vv9k
reviewed
Feb 21, 2023
| }} | ||
| }; | ||
| ( | ||
| Reize $it:ident: $base:ident -> $resp:ident $ep:expr, $ret:expr $(, $extra:expr)* |
Owner
There was a problem hiding this comment.
I'd suggest implementing it straight in src/api/container.rs as this macros are mostly for methods that appear on multiple structs like inspect or list. As the time passes I'm personally leaning more towards implementing it directly for each struct rather than by macro as it improves code search-ability.
Owner
|
Hey @casibbald , It's been a while and I was thinking of adding this. Do you still plan on working on this? |
Contributor
Author
|
Been incredibly busy with work, and still have deadlines over the next week.
If it's not too late I will pick it up then.
…On Sat, 25 Mar 2023 at 08:06, Wojciech Kępka ***@***.***> wrote:
Hey @casibbald <https://github.com/casibbald> , It's been a while and I
was thinking of adding this. Do you still plan on working on this?
—
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6C33CFLHG7GZLNI4SSLLW52DPZANCNFSM6AAAAAAVCILK5A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
Sure thing :) Just wanted to confirm you still want to work on this. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes: #xxx
How did you verify your change:
What (if anything) would need to be called out in the CHANGELOG for the next release: