docs: inventory dead code and dependencies (Fixes #2233) - #3378
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
OpenCodeReview — automatic reviews suspendedAutomatic OCR reviews are suspended for this PR after 2 of 2 automatic reviews. To get more reviews you can:
OpenCodeReview — PR #3378
|
WalkthroughBefore this PR, issue #2233 lacked structured planning artifacts, so the work to inventory dead code and dependencies across workspaces was not formally documented or organized. After this PR, the repository includes dedicated planning documents under project-plans/issue2233/, with inventory.md capturing the current state of dead code and dependencies and plan.md outlining the remediation approach. This gives contributors a clear, shared reference for tracking and cleaning up unused code and stale dependencies. Release NotesDocumentation
Changes
Magnitude🎯 1 (S) Related
Pre-merge Checks
Walkthrough generated by LLxprt PR Review. Planner issue: #2256 |
Review triage
No PR review produced a Blocker-Fix or In-scope-Fix finding. Both independent local Deepthinker reviews were completed before publication, and every Blocker-Fix and In-scope-Fix finding from those reviews is resolved in the inventory. |
Review triage correctionThe previous StepFun
The command exited 0 and returned a valid three-line haiku. No smoke-test blocker remains. The PR still changes only the two issue documents relative to |
TLDR
Documents a reproducible dead-code and dependency inventory for all 16 direct workspaces. The report identifies four high-confidence source candidates and 57 dependency-declaration candidates, classifies unsafe analyzer findings, and proposes package-focused cleanup slices. It changes no production code, tests, manifests, lockfiles, workflows, dependencies, or permanent analysis configuration.
Dive Deeper
The inventory compares ts-prune, depcheck, Knip, test-file-filtered Madge, package metadata, exact reference searches, and targeted TypeScript analysis. Findings are grouped into the six issue buckets:
The four high-confidence source candidates are
ProviderRuntimeScopeError,orUndefined,packages/mcp/src/auth/oauth-provider-dependencies.ts, and the redundantpackages/settings/src/types.tsre-export file. The 57 dependency rows remain experiment proposals rather than confirmed removals.Two independent Deepthinker reviews completed. All Blocker-Fix and In-scope-Fix findings were incorporated. Both permitted local Open Code Review attempts skipped because no files were selected and produced no comments.
The branch is based on
dev/0.12.0, and the target-relative diff contains only the two issue documents. Local test, lint, typecheck, format, and build gates passed on the retargeted candidate. After the StepFun profile reported that the account had no active subscription, the user authorized the ZAI profile for the smoke gate. The ZAI smoke passed with exit 0 and returned a three-line haiku.Reviewer Test Plan
project-plans/issue2233/inventory.mdcontains one coverage row for each of the 16 direct workspaces.project-plans/issue2233/plan.mdandproject-plans/issue2233/inventory.md.Local verification performed:
npm run test: passednpm run lint: passednpm run typecheck: passednpm run format: passed; no unexpected tracked changesnpm run build: passedbun scripts/start.ts --profile-load zai "write me a haiku and nothing else": passed; exit 0 with a valid three-line haikuTesting Matrix
Linked issues / bugs
Fixes #2233