Skip to content

fix: publish actionable SDD ownership diagnostics - #650

Merged
efraespada merged 4 commits into
developfrom
bugfix/636-pre-branch-sdd-ownership-analysis-fails-without-an-actionable-issue-diagnostic-or-clarification-card
Oct 21, 2026
Merged

efraespada merged 4 commits into
developfrom
bugfix/636-pre-branch-sdd-ownership-analysis-fails-without-an-actionable-issue-diagnostic-or-clarification-card

Conversation

@efraespada

@efraespada efraespada commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Pre-branch SDD ownership failures now produce safe, actionable issue diagnostics while keeping catalog validation fail-closed. Maintainers can clarify ownership and rerun analysis without the rejected decision authorizing branch readiness.

What changed

  • Classified five ownership rejection cases with closed diagnostic reasons that omit proposed values and provider output.
  • Added an issue-bound status card that is reused for repeated failures and updated after valid ownership analysis, without granting readiness.
  • Documented the one-analysis-per-invocation recovery flow while retaining existing publication and branch-readiness checks.

Validation

  • Author-provided evidence reports 127 focused domain and use-case tests, including 21 added cases.
  • Author-provided evidence reports typecheck, lint, specification and documentation validators, regenerated Action and CLI bundles, bundle validation, diff whitespace check, and AST-only Graphify update.

Closes #636

@docs-page

docs-page Bot commented Oct 21, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~650

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XL Indicates that the issue or task is extra large in scope and complexity. state:ai-processing labels Oct 21, 2026
@vypbot
vypbot self-requested a review October 21, 2026 11:39
@vypbot vypbot added the 85% Progress: 85% label Oct 21, 2026
@vypbot vypbot added this to vypdev Oct 21, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 21, 2026
@vypbot
vypbot changed the base branch from develop to master October 21, 2026 11:40
@vypbot
vypbot changed the base branch from master to develop October 21, 2026 11:40
@vypbot

vypbot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on eb100c3.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: eb100c3db970; base: a280c14ea70f; reason: protected-path.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.12%. Comparing base (274db40) to head (eb100c3).
⚠️ Report is 1578 commits behind head on develop.

Files with missing lines Patch % Lines
...ation/usecases/sdd/pre_branch_sdd_gate_use_case.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #650      +/-   ##
===========================================
+ Coverage    90.94%   94.12%   +3.17%     
===========================================
  Files          135      951     +816     
  Lines         6251    30614   +24363     
  Branches      1338     8989    +7651     
===========================================
+ Hits          5685    28814   +23129     
- Misses         172      705     +533     
- Partials       394     1095     +701     
Files with missing lines Coverage Δ
...application/policies/sdd_analysis_status_policy.ts 100.00% <100.00%> (ø)
src/domain/pre_branch_sdd.ts 86.18% <100.00%> (ø)
...ation/usecases/sdd/pre_branch_sdd_gate_use_case.ts 89.36% <93.75%> (ø)

... and 1015 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-without-an-actionable-issue-diagnostic-or-clarification-card
@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

@efraespada
efraespada merged commit 710547d into develop Oct 21, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

85% Progress: 85% size: XL Indicates that the issue or task is extra large in scope and complexity. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Pre branch SDD ownership analysis fails without an actionable issue diagnostic or clarification card

3 participants