Repository navigation
fix: retain actionable finding mutation diagnostics - #651
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
Bugbot: review complete
|
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #651 +/- ##
===========================================
+ Coverage 90.94% 94.13% +3.18%
===========================================
Files 135 953 +818
Lines 6251 30663 +24412
Branches 1338 9007 +7669
===========================================
+ Hits 5685 28864 +23179
- Misses 172 705 +533
- Partials 394 1094 +700
🚀 New features to boost your workflow:
|
…-reconciliation-with-opaque-provider-unavailable
|
Fixed the batch diagnostic finding in 5e637f9: the review publisher now binds identity/count to its queued new findings, adds the represented overflow count, and leaves the ID unavailable for overflow-only summaries. Mixed existing/new and overflow-only regressions pass. Added non-object provider rejection coverage. The Action synchronized develop first; final checks and fresh review are running. |
|
Final local validation on 5e637f9: 689 suites passed; 11,255 tests passed and 35 repository-defined skips. All coverage budgets passed; setup acceptance ledger remains 336/350 with the same 14 explicitly open entries. Bundles, package, typecheck, lint, documentation, specification and workflow validation passed. Bugbot independently reports complete coverage, one fixed finding and zero active/unknown/verification findings for this exact head. |
…-reconciliation-with-opaque-provider-unavailable
|
/copilot recheck |
|
1 finding was dismissed. |
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on14169d6. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit cb82695 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Issue comment failures are reported as PR review failures —
src/application/usecases/steps/commit/bugbot/publish_findings_use_case.ts:65
A finding mutation could fail after native review publication while the provider operation, finding and HTTP facts were discarded. Retain sanitized metadata at the adapter boundary, bind it to the publication/resolution stage and finding, and carry the correct semantic error through reconciliation and localized recovery details.
Completed reviews, comments and dismissal state remain intact. A fault-injection regression publishes a native review, fails later thread reconciliation, and retries without duplicate reviews/threads or lost dismissal. Conversation truncation remains independently partial and now identifies its exact retained provider records without exposing comment text.
Validation: 190 focused tests; 49 workflow tests for the updated diagnostic; 56 architecture tests; full-suite coverage budgets and setup acceptance ledger; typecheck/lint; documentation/specification validators; regenerated bundles and npm package validation; Graphify update. CI provides final full-suite and platform evidence. The original consumer's provider/API cause remains unknown; no live consumer recovery is claimed.
Closes #646