Skip to content

fix: retain actionable finding mutation diagnostics - #651

Merged
efraespada merged 6 commits into
developfrom
bugfix/646-bug-bugbot-persists-a-review-then-fails-reconciliation-with-opaque-provider-unavailable
Oct 21, 2026
Merged

efraespada merged 6 commits into
developfrom
bugfix/646-bug-bugbot-persists-a-review-then-fails-reconciliation-with-opaque-provider-unavailable

Conversation

@efraespada

@efraespada efraespada commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

A finding mutation could fail after native review publication while the provider operation, finding and HTTP facts were discarded. Retain sanitized metadata at the adapter boundary, bind it to the publication/resolution stage and finding, and carry the correct semantic error through reconciliation and localized recovery details.

Completed reviews, comments and dismissal state remain intact. A fault-injection regression publishes a native review, fails later thread reconciliation, and retries without duplicate reviews/threads or lost dismissal. Conversation truncation remains independently partial and now identifies its exact retained provider records without exposing comment text.

Validation: 190 focused tests; 49 workflow tests for the updated diagnostic; 56 architecture tests; full-suite coverage budgets and setup acceptance ledger; typecheck/lint; documentation/specification validators; regenerated bundles and npm package validation; Graphify update. CI provides final full-suite and platform evidence. The original consumer's provider/API cause remains unknown; no live consumer recovery is claimed.

Closes #646

@docs-page

docs-page Bot commented Oct 21, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~651

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review October 21, 2026 12:01
@vypbot vypbot added this to vypdev Oct 21, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 21, 2026
@vypbot
vypbot changed the base branch from develop to master October 21, 2026 12:02
@vypbot
vypbot changed the base branch from master to develop October 21, 2026 12:02
@vypbot vypbot added size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. 85% Progress: 85% labels Oct 21, 2026
@vypbot

vypbot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 14169d6.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 14169d67c556; base: 710547de0c51; reason: protected-path.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.10145% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.13%. Comparing base (274db40) to head (14169d6).
⚠️ Report is 1583 commits behind head on develop.

Files with missing lines Patch % Lines
...teps/commit/bugbot/load_bugbot_context_use_case.ts 0.00% 0 Missing and 1 partial ⚠️
...s/commit/bugbot/mark_findings_resolved_workflow.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #651      +/-   ##
===========================================
+ Coverage    90.94%   94.13%   +3.18%     
===========================================
  Files          135      953     +818     
  Lines         6251    30663   +24412     
  Branches      1338     9007    +7669     
===========================================
+ Hits          5685    28864   +23179     
- Misses         172      705     +533     
- Partials       394     1094     +700     
Files with missing lines Coverage Δ
src/application/errors/bugbot_mutation_error.ts 100.00% <100.00%> (ø)
src/application/policies/bugbot_message_catalog.ts 100.00% <100.00%> (ø)
...tion/policies/bugbot_review_presentation_policy.ts 100.00% <100.00%> (ø)
...rc/application/ports/pull_request_review_errors.ts 100.00% <100.00%> (ø)
...ses/steps/commit/bugbot/apply_detected_findings.ts 100.00% <100.00%> (ø)
...cases/steps/commit/bugbot/bugbot_review_context.ts 100.00% <100.00%> (ø)
...s/steps/commit/bugbot/publish_findings_use_case.ts 100.00% <100.00%> (ø)
.../steps/commit/bugbot/publish_pr_review_comments.ts 92.63% <100.00%> (ø)
...t/bugbot/reconcile_bugbot_review_state_use_case.ts 100.00% <100.00%> (ø)
...synchronize_bugbot_review_presentation_use_case.ts 98.88% <100.00%> (ø)
... and 9 more

... and 1001 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada

Copy link
Copy Markdown
Member Author

Fixed the batch diagnostic finding in 5e637f9: the review publisher now binds identity/count to its queued new findings, adds the represented overflow count, and leaves the ID unavailable for overflow-only summaries. Mixed existing/new and overflow-only regressions pass. Added non-object provider rejection coverage. The Action synchronized develop first; final checks and fresh review are running.

@efraespada

Copy link
Copy Markdown
Member Author

Final local validation on 5e637f9: 689 suites passed; 11,255 tests passed and 35 repository-defined skips. All coverage budgets passed; setup acceptance ledger remains 336/350 with the same 14 explicitly open entries. Bundles, package, typecheck, lint, documentation, specification and workflow validation passed. Bugbot independently reports complete coverage, one fixed finding and zero active/unknown/verification findings for this exact head.

…-reconciliation-with-opaque-provider-unavailable
@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

@vypbot

vypbot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

1 finding was dismissed.

@vypbot vypbot added state:ai-processing 90% Progress: 90% and removed 85% Progress: 85% labels Oct 21, 2026

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 14169d6. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit cb82695 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • low: Issue comment failures are reported as PR review failures — src/application/usecases/steps/commit/bugbot/publish_findings_use_case.ts:65

Comment thread src/application/usecases/steps/commit/bugbot/publish_findings_use_case.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

90% Progress: 90% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - bug Bugbot persists a review then fails reconciliation with opaque provider.unavailable

3 participants